-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: check NotNullFlag of columns when simplifying binary operations (#24049) #24063
expression: check NotNullFlag of columns when simplifying binary operations (#24049) #24063
Conversation
/run-all-tests |
@eurekaka you're already a collaborator in bot's repo. |
c18c506
to
9f573ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 54267568e928d164fddc9a7a39e7149cdf4b9284
|
Signed-off-by: ti-srebot <[email protected]>
0c7a046
to
2bd8b50
Compare
/merge |
/run-integration-copr-test |
/merge |
/run-common-test |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #24049 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24063
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #23891
Problem Summary:
Wrong result of queries.
What is changed and how it works?
What's Changed:
Check NotNullFlag in
refineArgs
before saying that the result of the expression is exceptional.Related changes
Check List
Tests
Side effects
N/A
Release note