Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: do not build MPP plan for scan with virtual columns (#23980) #24058

Merged
merged 6 commits into from
Apr 15, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 15, 2021

cherry-pick #23980 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24058

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/24058:release-5.0-05e584f145f1

What problem does this PR solve?

Issue Number: close #23886

Problem Summary:

Planner reports resolve index failure for MPP plan on virtual columns.

What is changed and how it works?

What's Changed:

Avoid generating MPP plan when the scan contains virtual columns.

How it Works:

If we enable MPP plan for such kind of cases, we need to add an extra projection node above to prune the newly appended columns, as what we do for copTask, otherwise we would get wrong query results. However, for a MPP task, we may attach plan nodes such as projection, hash aggregation and hash join upon the scan node, which would change the schema of the plan tree, so we have no idea of the target schema that the plan tree should be projected to then. Unlike copTask in which the PhysicalTableReader is the counterpart of DataSource, so we can add the projection upon the PhysicalTableReader, while in mppTask, the PhysicalTableReader is acting more like a data receiver, instead of the counterpart of the DataSource.

Meanwhile, I am not sure whether MPP execution engine can handle plan snippets which contain virtual columns, since I noticed that in addPushedDownSelectionToMppTask, no MPP task would be produced if the pushed down filter contains virtual columns.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Do not build MPP plan for scan with virtual columns

@ti-srebot ti-srebot requested review from a team as code owners April 15, 2021 11:34
@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team April 15, 2021 11:34
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/execution SIG execution sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 15, 2021
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Apr 15, 2021
@ti-srebot
Copy link
Contributor Author

@eurekaka you're already a collaborator in bot's repo.

@eurekaka eurekaka added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Apr 15, 2021
@eurekaka
Copy link
Contributor

/run-integration-compatibility-test

Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021
@zz-jason
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5b28dfe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 15, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit aa03cec into pingcap:release-5.0 Apr 15, 2021
@eurekaka eurekaka deleted the release-5.0-05e584f145f1 branch April 16, 2021 02:57
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.0.0 ga, v5.0.1 Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants