Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: typo fix for distinct-agg-push-down #24011

Merged
merged 6 commits into from
Apr 16, 2021
Merged

config: typo fix for distinct-agg-push-down #24011

merged 6 commits into from
Apr 16, 2021

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Apr 14, 2021

What problem does this PR solve?

Issue Number: close #24001

Problem Summary:

What is changed and how it works?

What's Changed: config distinct-agg-push-down typo fix

Check List

Tests

  • No code

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2021
xhebox
xhebox approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@xhebox xhebox requested a review from a team April 15, 2021 02:13
@XuHuaiyu
Copy link
Contributor

Need test case.

@xhebox
Copy link
Contributor

xhebox commented Apr 15, 2021

Introduced here, c28a695. So we need to cherry-pick back to 5.0 and 5.0-rc, I think. @b41sh

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2021
@b41sh
Copy link
Member Author

b41sh commented Apr 15, 2021

Need test case.

I add some test, PTAL @XuHuaiyu

@b41sh
Copy link
Member Author

b41sh commented Apr 15, 2021

Introduced here, c28a695. So we need to cherry-pick back to 5.0 and 5.0-rc, I think. @b41sh

ok

@eurekaka
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@eurekaka: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor

xhebox commented Apr 16, 2021

/label needs-cherry-pick-5.0

@tangenta
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2021
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6fba2c1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 873fbfd into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 16, 2021
@b41sh @ti-srebot
cherry pick pingcap#24011 to release-5.0
f739598 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24094

@windtalker windtalker mentioned this pull request Jun 15, 2021
Closed
ti-chi-bot pushed a commit that referenced this pull request Aug 12, 2021
@ti-srebot
config: typo fix for distinct-agg-push-down (#24011) (#24094)
4f9b0b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
component/config needs-cherry-pick-release-5.0 sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

distinct-agg-push-down is in config.toml.example but can't be found in @@tidb_config in 5.0.0
7 participants
@b41sh @XuHuaiyu @xhebox @eurekaka @ti-chi-bot @tangenta @ti-srebot