Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: don't propagateColumnEQ joinCondition when nullSensitive #23989

Merged
merged 7 commits into from
Apr 14, 2021
Merged

expression: don't propagateColumnEQ joinCondition when nullSensitive #23989

merged 7 commits into from
Apr 14, 2021

Conversation

wshwsh12
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #23889

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch 4.0, 5.0

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Fix wrong results for in clause.

@wshwsh12 wshwsh12 requested a review from a team as a code owner April 13, 2021 08:36
@wshwsh12 wshwsh12 requested review from lzmhhh123 and removed request for a team April 13, 2021 08:36
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 13, 2021
@ichn-hu ichn-hu mentioned this pull request Apr 13, 2021
Closed
@wshwsh12 wshwsh12 requested a review from eurekaka April 14, 2021 02:41
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 14, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2021
eurekaka
eurekaka reviewed Apr 14, 2021
View reviewed changes
expression/constant_propagation.go Outdated
visited = s.deriveConds(outerCol, innerCol, mergedSchema, lenJoinConds, visited, false)
if !s.nullSensitive {
visited = s.deriveConds(outerCol, innerCol, mergedSchema, lenJoinConds, visited, false)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should include line 582 into this check as well?

@wshwsh12 wshwsh12 requested a review from eurekaka April 14, 2021 07:38
eurekaka
eurekaka approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • eurekaka
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2021
@wshwsh12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d065449

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2021
@wshwsh12
Copy link
Contributor Author

/run-all-tests

@wshwsh12
Copy link
Contributor Author

/rebuild

@ti-chi-bot ti-chi-bot merged commit 07d2b84 into pingcap:master Apr 14, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 14, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#23989 to release-4.0
4c14f78 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 14, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #24022

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 14, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#23989 to release-5.0
0df73e2 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 14, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24023

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
expression: don't propagateColumnEQ joinCondition when nullSensitive (#…
112c972 
…23989) (#24023)
ti-chi-bot pushed a commit that referenced this pull request May 6, 2021
@ti-srebot
expression: don't propagateColumnEQ joinCondition when nullSensitive (#…
9bc8258 
…23989) (#24022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@eurekaka eurekaka eurekaka approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executor: wrong results for in clause
5 participants
@wshwsh12 @ti-chi-bot @ti-srebot @eurekaka @lzmhhh123