*: add builtin function UNIX_TIMESTAMP #2369
Conversation
| @@ -745,3 +745,43 @@ func parseDayInterval(sc *variable.StatementContext, value types.Datum) (int64, | |||
| } | |||
| return value.ToInt64(sc) | |||
| } | |||
|
|
|||
| func builtinUnixTimestamp(args []types.Datum, ctx context.Context) (d types.Datum, err error) { | |||
| return | ||
| } | ||
| if e != nil { | ||
| return |
There was a problem hiding this comment.
I find mysql default behavior is return 0, when input data is wrong...
| @@ -278,6 +278,7 @@ import ( | |||
| trim "TRIM" | |||
| rtrim "RTRIM" | |||
| ucase "UCASE" | |||
| unixTimestamp "UNIX_TIMESTAMP" | |||
There was a problem hiding this comment.
Is UNIX_TIMESTAMP a keyword or non-keyword-token?
There was a problem hiding this comment.
it's not a keyword or non-keyword.
https://dev.mysql.com/doc/refman/5.7/en/keywords.html
|
@tiancaiamao Please fix CI. |
|
PTAL |
|
@tiancaiamao Fix the conflict. |
Conflicts: expression/builtin_time_test.go
|
LGTM |
| var ( | ||
| t types.Time | ||
| t1 time.Time | ||
| e error |
There was a problem hiding this comment.
There exists an err so you needn't to declare an error e.
There was a problem hiding this comment.
I know, but if I use if err != nil { return } , this function would return error, which is not the same as mysql behavior.
|
Ping @tiancaiamao |
Conflicts: plan/typeinferer_test.go
|
LGTM |
|
For invalid input, |
For issue #236