Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add testleak after checking and testing #23324

Merged
merged 9 commits into from
Mar 18, 2021
Merged

test: add testleak after checking and testing #23324

merged 9 commits into from
Mar 18, 2021

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Mar 15, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

the testleak in #23056 results in goroutine leak, thus #23288 works around the case. After checking the code of testleak and testing, we propose this PR to testing goroutine leak via testleak.

Release note

  • No release note

@fzhedu fzhedu requested a review from hanfei1991 March 15, 2021 12:53
@fzhedu fzhedu requested a review from a team as a code owner March 15, 2021 12:53
@fzhedu fzhedu requested review from lzmhhh123 and removed request for a team March 15, 2021 12:53
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Mar 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2021
@lzmhhh123
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@lzmhhh123: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hanfei1991
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Mar 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 03287da

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Mar 18, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 6049ed7 into pingcap:master Mar 18, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 18, 2021
@fzhedu @ti-srebot
cherry pick pingcap#23324 to release-5.0
458048b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 18, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #23410

ti-chi-bot pushed a commit that referenced this pull request Mar 18, 2021
@ti-srebot
test: add testleak after checking and testing (#23324) (#23410)
b3e7627
SabaPing pushed a commit to SabaPing/tidb that referenced this pull request Mar 25, 2021
@fzhedu @SabaPing
test: add testleak after checking and testing (pingcap#23324)
a1c2185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fzhedu @lzmhhh123 @ti-chi-bot @ti-srebot @hanfei1991