Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: remove kv.Snaphost from store/tikv #23318

Merged
merged 2 commits into from
Mar 15, 2021
Merged

store/tikv: remove kv.Snaphost from store/tikv #23318

merged 2 commits into from
Mar 15, 2021

Conversation

AndreMouche
Copy link
Contributor

Signed-off-by: AndreMouche

What problem does this PR solve?

This PR removes the usage of kv.Snapshot from package store/tikv
Part of #22513

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label Mar 15, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 15, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Mar 15, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@AndreMouche AndreMouche changed the title remove kv.Snaphost from store/tikv store/tikv: remove kv.Snaphost from store/tikv Mar 15, 2021
@AndreMouche
Copy link
Contributor Author

/run-check_title

@AndreMouche
Copy link
Contributor Author

/run check-title

@AndreMouche
fix linting
ec3d079 
Signed-off-by: shirly <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 15, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • andylokandy
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2021
@andylokandy
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ec3d079

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2021
@ti-chi-bot ti-chi-bot merged commit cad8e15 into pingcap:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@andylokandy andylokandy andylokandy approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndreMouche @sre-bot @ti-chi-bot @andylokandy @disksing