Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix a panic caused by unmatched FieldNames and ColsInfo in partition pruning #23242

Merged
merged 7 commits into from
Mar 11, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 10, 2021

What problem does this PR solve?

Issue Number: close #22635

Problem Summary: planner: fix a panic caused by unmatched FieldNames and ColsInfo

What is changed and how it works?

The panic is caused by we propagate unmatched FieldsName and ColsInfo to the expression rewriter in processHashPartition.
This PR solves this problem by reconstructing FieldsName there before calling the expression rewriter.

Tests

  • Unit test

Release note

  • planner: fix a panic caused by unmatched FieldNames and ColsInfo

@qw4990 qw4990 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Mar 10, 2021
@qw4990 qw4990 requested review from winoros and rebelice March 10, 2021 11:28
@qw4990 qw4990 requested a review from a team as a code owner March 10, 2021 11:28
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2021
@ichn-hu ichn-hu mentioned this pull request Mar 10, 2021
@Reminiscent
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 318c919

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2021
@ti-chi-bot
Copy link
Member

@qw4990: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 11, 2021

/run-unit-test

@qw4990 qw4990 merged commit 32d54d2 into pingcap:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime error: slice bounds out of range [:2] with capacity 1
4 participants