Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: remove unstable tiflash fallback testcase #23226

Merged
merged 2 commits into from
Mar 10, 2021
Merged

server: remove unstable tiflash fallback testcase #23226

merged 2 commits into from
Mar 10, 2021

Conversation

xuyifangreeneyes
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

#23103 introduces an unstable testcase about TiFlash fallback, which may fail with probability.

What is changed and how it works?

What's Changed:

Remove the unstable part of the testcase.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • remove unstable TiFlash fallback testcase

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2021
@xuyifangreeneyes
Copy link
Contributor Author

/cc @winoros

@ti-chi-bot ti-chi-bot requested a review from winoros March 10, 2021 03:40
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 10, 2021
@ti-chi-bot
Copy link
Member

@qw4990: /lgtm is only allowed for the reviewers in list.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor

qw4990 commented Mar 10, 2021

/LGTM

@ti-chi-bot
Copy link
Member

@qw4990: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Reminiscent
Reminiscent approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

@Reminiscent: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@Reminiscent: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xuyifangreeneyes
Copy link
Contributor Author

/run-unit-test

@lysu
Copy link
Contributor

lysu commented Mar 10, 2021

/merge

@ti-chi-bot
Copy link
Member

@lysu: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lysu
Copy link
Contributor

lysu commented Mar 10, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2021
@lysu
Copy link
Contributor

lysu commented Mar 10, 2021

/cc @coocood

@ti-chi-bot ti-chi-bot requested a review from coocood March 10, 2021 10:36
@coocood
Copy link
Member

coocood commented Mar 10, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • lysu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2021
@coocood
Copy link
Member

coocood commented Mar 10, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 04894b3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2021
@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lysu
Copy link
Contributor

lysu commented Mar 10, 2021

/run-tics-test

@coocood
Copy link
Member

coocood commented Mar 10, 2021

/run-check_dev_2

@coocood
Copy link
Member

coocood commented Mar 10, 2021

/rebuild

@coocood coocood merged commit 9fe1bde into pingcap:master Mar 10, 2021
@xuyifangreeneyes xuyifangreeneyes deleted the remove-unstable-test branch March 10, 2021 12:14
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros Awaiting requested review from winoros

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xuyifangreeneyes @ti-chi-bot @qw4990 @Reminiscent @lysu @coocood