executor: fix the bug of step value overflow when split regions #23206
Conversation
Signed-off-by: mantuliu <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
the
size/M
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
|
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
sourcelliu
changed the title
|
@wshwsh12 PTAL thanks. |
executor/split_test.go
Outdated
| handleCols: core.NewIntHandleCols(&expression.Column{RetType: types.NewFieldType(mysql.TypeLonglong)}), | ||
| lower: []types.Datum{types.NewDatum(-9223372036854775808)}, | ||
| upper: []types.Datum{types.NewDatum(9223372036854775807)}, | ||
| num: 4, |
There was a problem hiding this comment.
I add some edge test. And in the Integration Testing, the mysql client get the result:
mysql> create table if not exists `t1` (`id` bigint);
Query OK, 0 rows affected (0.00 sec)
mysql> split table `t1` between (-9223372036854775808) and (9223372036854775807) regions 1;
ERROR 1105 (HY000): Split table `t1` region step value should more than 1000, step -1 is invalid
|
why close it? @mantuliu |
ti-chi-bot
added
the
needs-rebase
|
@mantuliu: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: mantuliu [email protected]
What problem does this PR solve?
Issue Number: close #23159
Problem Summary:
What is changed and how it works?
How it Works:
Use math/big package.
Related changes
pingcap/docs/pingcap/docs-cn: noCheck List
Tests
Release note