Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fixed a bug that prevented SPM from taking effect #23197

Merged
merged 7 commits into from
Mar 9, 2021
Merged

planner: fixed a bug that prevented SPM from taking effect #23197

merged 7 commits into from
Mar 9, 2021

Conversation

rebelice
Copy link
Contributor

@rebelice rebelice commented Mar 9, 2021

What problem does this PR solve?

Issue Number: close #23190

Problem Summary:

SPM does not take effect without use database

What is changed and how it works?

What's Changed:

There is an error in the logic of obtaining binding, fix it now

How it Works:

If ctx.GetSessionVars().CurrentDB is "", we still restore the sql.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • fixed a bug that prevented SPM from taking effect

@rebelice rebelice requested a review from a team as a code owner March 9, 2021 08:03
@rebelice rebelice requested review from hanfei1991 and removed request for a team March 9, 2021 08:03
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 9, 2021
@rebelice
Copy link
Contributor Author

rebelice commented Mar 9, 2021

/sig planner

@ti-chi-bot ti-chi-bot added the sig/planner SIG: Planner label Mar 9, 2021
@rebelice
Copy link
Contributor Author

rebelice commented Mar 9, 2021

/cc @qw4990

@ti-chi-bot ti-chi-bot requested a review from qw4990 March 9, 2021 08:04
@rebelice
Copy link
Contributor Author

rebelice commented Mar 9, 2021

/cc @XuHuaiyu

@ti-chi-bot ti-chi-bot requested a review from XuHuaiyu March 9, 2021 08:04
@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Mar 9, 2021
XuHuaiyu
XuHuaiyu reviewed Mar 9, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 9, 2021
eurekaka
eurekaka approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2021
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Mar 9, 2021

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • eurekaka

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 9, 2021
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Mar 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ea57d9c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2021
@rebelice
Copy link
Contributor Author

rebelice commented Mar 9, 2021

/run-all-tests

@ichn-hu ichn-hu mentioned this pull request Mar 9, 2021
Closed
@rebelice
Copy link
Contributor Author

rebelice commented Mar 9, 2021

/run-check_dev_2

@rebelice
Copy link
Contributor Author

rebelice commented Mar 9, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 1ca62a0 into pingcap:master Mar 9, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 9, 2021
@rebelice @ti-srebot
cherry pick pingcap#23197 to release-4.0
9d5ed9b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 9, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #23209

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 9, 2021
@rebelice @ti-srebot
cherry pick pingcap#23197 to release-5.0-rc
9e31de6 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 9, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0-rc in PR #23210

ti-chi-bot pushed a commit that referenced this pull request Mar 12, 2021
@ti-srebot
planner: fixed a bug that prevented SPM from taking effect (#23197) (#…
e579d1c 
…23209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@eurekaka eurekaka eurekaka approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPM doesn't take effect without use database
5 participants
@rebelice @XuHuaiyu @ti-chi-bot @ti-srebot @eurekaka