Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: add more test cases for global-stats with different analysis options #23169

Merged
merged 8 commits into from
Mar 8, 2021
Merged

statistics: add more test cases for global-stats with different analysis options #23169

merged 8 commits into from
Mar 8, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 8, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: statistics: add more test cases for global-stats with different analysis options

What is changed and how it works?

statistics: add more test cases for global-stats with different analysis options

Check List

Tests

  • Unit test

Release note

  • statistics: add more test cases for global-stats with different analysis options

@qw4990 qw4990 requested review from rebelice and Reminiscent March 8, 2021 08:28
@qw4990 qw4990 requested a review from a team as a code owner March 8, 2021 08:28
@qw4990 qw4990 requested review from winoros and removed request for a team March 8, 2021 08:28
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 8, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2021
Reminiscent
Reminiscent approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 8, 2021
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@Reminiscent: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 8, 2021

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 8, 2021

/run-unit-test

2 similar comments
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 8, 2021

/run-unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 8, 2021

/run-unit-test

@qw4990 qw4990 merged commit 4cc597a into pingcap:master Mar 8, 2021
@lysu lysu mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent approved these changes

@rebelice rebelice rebelice approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/statistics sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @ti-chi-bot @Reminiscent @rebelice