Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: add tests for analyze with dynamic partition prune mode #23113

Merged
merged 11 commits into from
Mar 5, 2021
Merged

statistics: add tests for analyze with dynamic partition prune mode #23113

merged 11 commits into from
Mar 5, 2021

Conversation

rebelice
Copy link
Contributor

@rebelice rebelice commented Mar 4, 2021

What problem does this PR solve?

  1. add tests for analyze with dynamic partition prune mode
  2. fix a bug when merging global topN

Tests

  • Unit test

Side effects

Release note

  • No release note

@rebelice rebelice requested a review from a team as a code owner March 4, 2021 09:44
@rebelice rebelice requested review from hanfei1991 and removed request for a team March 4, 2021 09:44
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 4, 2021
qw4990
qw4990 reviewed Mar 5, 2021
View reviewed changes
go.sum
Comment on lines +849 to +850
honnef.co/go/tools v0.1.2 h1:SMdYLJl312RXuxXziCCHhRsp/tvct9cGKey0yv95tZM=
honnef.co/go/tools v0.1.2/go.mod h1:NgwopIslSNH47DimFoV78dnkksY2EFtX0ajyb3K/las=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we change it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go mod tidy changes it.

qw4990
qw4990 reviewed Mar 5, 2021
View reviewed changes
statistics/cmsketch.go Outdated Show resolved Hide resolved
qw4990
qw4990 reviewed Mar 5, 2021
View reviewed changes
statistics/cmsketch.go Outdated
finalTopN.TopN = make([]TopNMeta, 0, n)
popedTopNPair := make([]TopNMeta, 0, uint32(numTop)-n)
for value, cnt := range counter {
data := hack.Slice(string(value))
if n > 0 && cnt >= lastTopCnt {
if n > 0 && remain > 0 && cnt >= lastTopCnt {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition remain > 0 may make the result unstable when multiple items have the same lastTopCnt.
Could we also update the sort algorithm above to make it stable?

Reminiscent
Reminiscent reviewed Mar 5, 2021
View reviewed changes
statistics/handle/handle_test.go
@@ -1069,6 +1069,32 @@ func (s *testStatsSuite) TestMergeIdxHist(c *C) {
c.Assert(len(rows.Rows()), Equals, 2)
}

func (s *testStatsSuite) TestAnalyzeWithDynamicPartitionPruneMode(c *C) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test LGTM

@qw4990
Copy link
Contributor

qw4990 commented Mar 5, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 5, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 5, 2021

/LGTM

Reminiscent
Reminiscent approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 5, 2021
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@Reminiscent: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9bf9857

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 5, 2021
@ti-chi-bot
Copy link
Member

@rebelice: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7fdfc44 into pingcap:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@Reminiscent Reminiscent Reminiscent approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

Assignees
No one assigned
Labels
component/statistics size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rebelice @qw4990 @ti-chi-bot @Reminiscent