-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: refactor and fix the usages of DecodeIndexKV for clustered index #23096
*: refactor and fix the usages of DecodeIndexKV for clustered index #23096
Conversation
c954d3f
to
9fa4c8a
Compare
/lgtm |
2a757f5
to
b44fe65
Compare
/run-check_dev_2 tikv=pr/9182 |
/run-all-tests |
/run-all-tests |
/run-unit-test |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9518be9
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e13700f
|
/run-unit-test |
@tangenta: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Problem Summary: Fix #23106.
In the process of the work "remove alter-primary-key configuration", I found
TestAddIndex5
should test the clustered index case but it doesn't because the configalter-primary-key
is enabled.For details, see #23106.
What is changed and how it works?
What's Changed:
Bugfix:
Test:
Refactor:
Related changes
NA
Check List
Tests
Side effects
NA
Release note