Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: report error for extended statistics register on partitioned tables #23089

Merged
merged 4 commits into from
Mar 4, 2021

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Mar 3, 2021

What problem does this PR solve?

Issue Number: close #23048

Problem Summary:

Not a problem, disable extended statistics on partitioned tables temporarily.

What is changed and how it works?

What's Changed:

Report error in alter table add stats_extended for partitioned tables.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Report error for extended statistics register on partitioned tables

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. component/statistics labels Mar 3, 2021
@eurekaka eurekaka requested review from qw4990 and time-and-fate March 3, 2021 12:10
@eurekaka eurekaka requested a review from a team as a code owner March 3, 2021 12:10
@eurekaka eurekaka requested review from lzmhhh123 and removed request for a team March 3, 2021 12:10
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2021
@eurekaka eurekaka removed the request for review from lzmhhh123 March 3, 2021 12:11
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 3, 2021
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

@time-and-fate: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@time-and-fate
Copy link
Member

/sig planner

@ti-chi-bot ti-chi-bot added the sig/planner SIG: Planner label Mar 4, 2021
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 4, 2021

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 4, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 4, 2021

/merge

@ti-chi-bot
Copy link
Member

@qw4990: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6ac85fc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 4, 2021
@ti-chi-bot
Copy link
Member

@eurekaka: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@eurekaka eurekaka merged commit 2cdd8a3 into pingcap:master Mar 4, 2021
@eurekaka eurekaka deleted the partition_ext branch March 4, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

report error if user registers extended statistics for a partitioned table temporarily
4 participants