Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support show stats_extended to inspect extended stats cache #23052

Merged
merged 4 commits into from
Mar 3, 2021
Merged

*: support show stats_extended to inspect extended stats cache #23052

merged 4 commits into from
Mar 3, 2021

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Mar 2, 2021

What problem does this PR solve?

Issue Number: close #23033

Problem Summary:

Not a problem, provide a new SQL interface to inspect extended stats cache

What is changed and how it works?

What's Changed:

Grab the extended stats cache and convert data to a readable format.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Support show stats_extended to inspect extended stats cache

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. component/statistics labels Mar 2, 2021
@eurekaka eurekaka requested review from a team as code owners March 2, 2021 11:31
@eurekaka eurekaka requested review from qw4990 and winoros and removed request for a team March 2, 2021 11:31
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Mar 2, 2021
winoros
winoros reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@winoros
Copy link
Member

winoros commented Mar 2, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2021
@eurekaka eurekaka requested a review from time-and-fate March 3, 2021 03:30
@eurekaka eurekaka requested a review from time-and-fate March 3, 2021 07:22
time-and-fate
time-and-fate approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

@time-and-fate: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@time-and-fate
Copy link
Member

/label sig/planner

@time-and-fate
Copy link
Member

/sig planner

@ti-chi-bot ti-chi-bot added the sig/planner SIG: Planner label Mar 3, 2021
time-and-fate
time-and-fate approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@time-and-fate: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 3, 2021
@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 3, 2021

/run-all-tests

@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 3, 2021

/run-all-tests

@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 3, 2021

/run-all-tests

@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 3, 2021

/run-e2e-test

1 similar comment
@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 3, 2021

/run-e2e-test

@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 3, 2021

/run-unit-test

@eurekaka eurekaka merged commit 93c1779 into pingcap:master Mar 3, 2021
@eurekaka eurekaka deleted the show_ext branch March 3, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/statistics sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support SHOW STATS_EXTENDED to inspect extended stats cache
4 participants
@eurekaka @winoros @ti-chi-bot @time-and-fate