statistics: add more test cases for global-level stats #23049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
the
size/L
Reminiscent
commented
Mar 2, 2021
statistics/handle/handle.go
Outdated
Comment on lines
419
to
425
| globalStats.Hg[i], err = statistics.MergePartitionHist2GlobalHist(sc, allHg[i], popedTopN, numBuckets) | ||
| if err != nil { | ||
| return | ||
| if numBuckets != 0 { | ||
| globalStats.Hg[i], err = statistics.MergePartitionHist2GlobalHist(sc, allHg[i], popedTopN, numBuckets) | ||
| if err != nil { | ||
| return | ||
| } | ||
| } else { | ||
| globalStats.Hg[i] = allHg[i][0].Copy() |
There was a problem hiding this comment.
Only use to avoid some bugs. It will be deleted until these bugs have been fixed.
qw4990
reviewed
Mar 2, 2021
|
/LGTM |
rebelice
approved these changes
Mar 4, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/run-all-tests |
qw4990
added
the
status/can-merge
ti-chi-bot
removed
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add more tests about global-level stats to ensure their correctness
What is changed and how it works?
Add more tests about global-level stats to ensure their correctness
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note