store/tikv: use original snapshot timestamp to resolve locks #23044
Conversation
sticnarf
added
type/enhancement
ti-chi-bot
added
the
size/M
Signed-off-by: Yilin Chen <[email protected]>
sticnarf
force-pushed
the
snapshot-max-ts-resolve
branch
from
2c80f91 to
f9f4419
Compare
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@youjiali1995: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: f9f4419
|
ti-chi-bot
added
the
status/can-merge
store/tikv/snapshot_fail_test.go
Outdated
| _, err = snapshot.Get(context.Background(), []byte("k2")) | ||
| c.Assert(err, ErrorMatches, ".*key not exist") | ||
|
|
||
| initialCommitTS := committer.commitTS |
Signed-off-by: Yilin Chen <[email protected]>
…/tidb into snapshot-max-ts-resolve
ti-chi-bot
removed
the
status/can-merge
|
@sticnarf: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-all-tests |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 1859023
|
ti-chi-bot
added
the
status/can-merge
|
@sticnarf: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
If an auto-commit point get meets a lock, it will get a timestamp from PD as the snapshot TS in retries. But we would better not use this new TS to resolve locks the first time, because it can push forward the minCommitTS. This is an unnecessary write.
What is changed and how it works?
As @youjiali1995 suggested, we can use the original snapshot timestamp to resolve locks. Then, if the lock is not from an async-commit transaction, using
MaxUint64ascallerStartTScan save one write at TIKV.Check List
Tests
Release note