Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix err check #23008

Merged
merged 3 commits into from
Mar 4, 2021
Merged

types: fix err check #23008

merged 3 commits into from
Mar 4, 2021

Conversation

Rameshhj
Copy link
Contributor

@Rameshhj Rameshhj commented Feb 28, 2021

What problem does this PR solve?

Issue Number: #22979

Problem Summary:

What is changed and how it works?

What's Changed: added err check

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2021
@Rameshhj Rameshhj marked this pull request as ready for review February 28, 2021 02:43
@Rameshhj Rameshhj requested a review from a team as a code owner February 28, 2021 02:43
@Rameshhj Rameshhj requested review from qw4990 and removed request for a team February 28, 2021 02:43
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2021
@zimulala
Copy link
Contributor

zimulala commented Mar 1, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2021
@zimulala
Copy link
Contributor

zimulala commented Mar 1, 2021

/cc @qw4990

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 3, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@djshow832: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b5abfb5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 3, 2021
@Rameshhj
Copy link
Contributor Author

Rameshhj commented Mar 3, 2021

/run-all-tests

@djshow832
Copy link
Contributor

/run-integration-copr-test /run-e2e-test

@ti-chi-bot ti-chi-bot merged commit 953de47 into pingcap:master Mar 4, 2021
@djshow832
Copy link
Contributor

djshow832 commented Mar 4, 2021

PTAL at the e2e-test (https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_e2e_tests/detail/tidb_e2e_tests/2986/pipeline):

FAIL: global_kill_test.go:422: TestGlobalKillSuite.TestLostConnection
global_kill_test.go:479:
    c.Assert(r.err, NotNil)
    value = nil

@Tjianke

@Rameshhj
Copy link
Contributor Author

Rameshhj commented Mar 4, 2021

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_e2e_tests/detail/tidb_e2e_tests/2986/pipeline

Last time I checked, this error seems to happen in most recently merged PRs. Any Chance the test itself needs fixing?

check this #20220 for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants