-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx: fix err check #23000
sessionctx: fix err check #23000
Conversation
sessionctx/variable/varsutil_test.go
Outdated
SetSessionSystemVar(v, TiDBDDLReorgWorkerCount, types.NewIntDatum(int64(maxDDLReorgWorkerCount)+1)) | ||
er := SetSessionSystemVar(v, TiDBDDLReorgWorkerCount, types.NewIntDatum(int64(maxDDLReorgWorkerCount)+1)) | ||
c.Assert(er, IsNil) | ||
// shouldn't this assert tests for result from line 284 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove line285-286, and we can use err
instead of er
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After removing line285-286 and rename er
to err
, c.Assert(terror.ErrorEqual(err, ErrWrongValueForVar), IsTrue)
raises error, not sure if I should change to IsFalse
or fix the test, since this line originally checks for err
in line 281.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I file #23017. I think we can add a // FIXME: issue #23017
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixme
added.
/LGTM |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0bd5401df706ecc6decda06411f5defea30a77e2
|
5fc05d6
to
5001e15
Compare
Update tests after #23017 fixed. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5001e15
|
@Tjianke: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: #22979
Problem Summary:
What is changed and how it works?
What's Changed: added err check
Check List
Tests
Release note