Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: fix data race caused by config.Labels #22977

Merged
merged 17 commits into from
Mar 1, 2021
Merged

config: fix data race caused by config.Labels #22977

merged 17 commits into from
Mar 1, 2021

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Feb 26, 2021

Signed-off-by: Song Gao [email protected]

What problem does this PR solve?

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/65973/

Problem Summary:

What is changed and how it works?

Fix the data race cuased by editing global config

Check List

Tests

  • Unit test

Release note

  • No release note

@Yisaer
fix race
7572b68 
Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer requested a review from a team as a code owner February 26, 2021 09:17
@Yisaer Yisaer requested review from qw4990 and removed request for a team February 26, 2021 09:17
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2021
@Yisaer Yisaer changed the title fix race config: fix data race caused by config.Lables Feb 26, 2021
@Yisaer
Copy link
Contributor Author

Yisaer commented Feb 26, 2021

/cc @xhebox

@ti-chi-bot ti-chi-bot requested a review from xhebox February 26, 2021 09:22
@Yisaer
fix lint
609267a 
Signed-off-by: Song Gao <[email protected]>
xhebox
xhebox reviewed Feb 26, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

expression/integration_test.go Outdated Show resolved Hide resolved
@Yisaer
address the comment
c178887 
Signed-off-by: Song Gao <[email protected]>
@xhebox
Copy link
Contributor

xhebox commented Feb 26, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 26, 2021
@tangenta tangenta changed the title config: fix data race caused by config.Lables config: fix data race caused by config.Labels Feb 26, 2021
@tangenta
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 26, 2021
@xhebox
Copy link
Contributor

xhebox commented Feb 26, 2021

/merge

@ti-chi-bot
Copy link
Member

@xhebox: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 26, 2021
@xhebox
Copy link
Contributor

xhebox commented Feb 27, 2021

/run-check_dev

@Rustin170506
Copy link
Member

/run-check_dev_2

@xhebox
Copy link
Contributor

xhebox commented Feb 27, 2021

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 27, 2021
@Yisaer
fix test
5b00a48 
Signed-off-by: Song Gao <[email protected]>
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2021

/run-all-tests

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2021

/run-all-tests

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2021

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e8fe146

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2021
@xhebox
Copy link
Contributor

xhebox commented Mar 1, 2021

/run-unit-test

@xhebox
Copy link
Contributor

xhebox commented Mar 1, 2021

/run-e2e-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2021
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2021

/run-all-tests

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2021

/run-all-tests

@xhebox
Copy link
Contributor

xhebox commented Mar 1, 2021

/run-e2e-test

@xhebox
Copy link
Contributor

xhebox commented Mar 1, 2021

/merge

@ti-chi-bot
Copy link
Member

@xhebox: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e484fec

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2021
@ti-chi-bot
Copy link
Member

@Yisaer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2021

/run-e2e-test

@ti-chi-bot ti-chi-bot merged commit e2fdb00 into pingcap:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox left review comments

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/config component/expression sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yisaer @xhebox @tangenta @ti-chi-bot @Rustin170506