Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: introduce setWithMemoryUsage to track set memory in AggExec. #22965

Merged
merged 6 commits into from
Mar 3, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 121 additions & 0 deletions executor/aggfuncs/set_with_memory_usage.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@
// Copyright 2021 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package aggfuncs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to move the package to util/set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. PTAL again


import (
"github.com/pingcap/tidb/util/set"
)

const (
// DefStringSetBucketMemoryUsage = bucketSize*(1+unsafe.Sizeof(string) + unsafe.Sizeof(struct{}))+2*ptrSize
DefStringSetBucketMemoryUsage = 8*(1+16+0) + 16
// DefFloat64SetBucketMemoryUsage = bucketSize*(1+unsafe.Sizeof(float64) + unsafe.Sizeof(struct{}))+2*ptrSize
DefFloat64SetBucketMemoryUsage = 8*(1+8+0) + 16
// DefInt64SetBucketMemoryUsage = bucketSize*(1+unsafe.Sizeof(int64) + unsafe.Sizeof(struct{}))+2*ptrSize
DefInt64SetBucketMemoryUsage = 8*(1+8+0) + 16
// Maximum average load of a bucket that triggers growth is 6.5.
// Represent as loadFactorNum/loadFactDen, to allow integer math.
loadFactorNum = 13
loadFactorDen = 2
)

// StringSetWithMemoryUsage is a string set with memory usage.
type StringSetWithMemoryUsage struct {
set.StringSet
bInMap int64
}

// NewStringSetWithMemoryUsage builds a string set.
func NewStringSetWithMemoryUsage(ss ...string) (setWithMemoryUsage StringSetWithMemoryUsage, memDelta int64) {
set := make(set.StringSet, len(ss))
setWithMemoryUsage = StringSetWithMemoryUsage{
StringSet: set,
bInMap: 0,
}
memDelta = DefStringSetBucketMemoryUsage * (1 << setWithMemoryUsage.bInMap)
for _, s := range ss {
memDelta += setWithMemoryUsage.Insert(s)
}
return setWithMemoryUsage, memDelta
}

// Insert inserts `val` into `s` and return memDelta.
func (s *StringSetWithMemoryUsage) Insert(val string) (memDelta int64) {
s.StringSet.Insert(val)
if s.Count() > (1<<s.bInMap)*loadFactorNum/loadFactorDen {
memDelta = DefStringSetBucketMemoryUsage * (1 << s.bInMap)
s.bInMap++
}
return memDelta + int64(len(val))
}

// Float64SetWithMemoryUsage is a float64 set with memory usage.
type Float64SetWithMemoryUsage struct {
set.Float64Set
bInMap int64
}

// NewFloat64SetWithMemoryUsage builds a float64 set.
func NewFloat64SetWithMemoryUsage(ss ...float64) (setWithMemoryUsage Float64SetWithMemoryUsage, memDelta int64) {
set := make(set.Float64Set, len(ss))
setWithMemoryUsage = Float64SetWithMemoryUsage{
Float64Set: set,
bInMap: 0,
}
memDelta = DefFloat64SetBucketMemoryUsage * (1 << setWithMemoryUsage.bInMap)
for _, s := range ss {
memDelta += setWithMemoryUsage.Insert(s)
}
return setWithMemoryUsage, memDelta
}

// Insert inserts `val` into `s` and return memDelta.
func (s *Float64SetWithMemoryUsage) Insert(val float64) (memDelta int64) {
s.Float64Set.Insert(val)
if s.Count() > (1<<s.bInMap)*loadFactorNum/loadFactorDen {
memDelta = DefFloat64SetBucketMemoryUsage * (1 << s.bInMap)
s.bInMap++
}
return memDelta + DefFloat64Size
}

// Int64SetWithMemoryUsage is a int set with memory usage.
type Int64SetWithMemoryUsage struct {
set.Int64Set
bInMap int64
}

// NewInt64SetWithMemoryUsage builds a int64 set.
func NewInt64SetWithMemoryUsage(ss ...int64) (setWithMemoryUsage Int64SetWithMemoryUsage, memDelta int64) {
set := make(set.Int64Set, len(ss))
setWithMemoryUsage = Int64SetWithMemoryUsage{
Int64Set: set,
bInMap: 0,
}
memDelta = DefInt64SetBucketMemoryUsage * (1 << setWithMemoryUsage.bInMap)
for _, s := range ss {
memDelta += setWithMemoryUsage.Insert(s)
}
return setWithMemoryUsage, memDelta
}

// Insert inserts `val` into `s` and return memDelta.
func (s *Int64SetWithMemoryUsage) Insert(val int64) (memDelta int64) {
s.Int64Set.Insert(val)
if s.Count() > (1<<s.bInMap)*loadFactorNum/loadFactorDen {
memDelta = DefInt64SetBucketMemoryUsage * (1 << s.bInMap)
s.bInMap++
}
return memDelta + DefInt64Size
}
94 changes: 94 additions & 0 deletions executor/aggfuncs/set_with_memory_usage_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
package aggfuncs

import (
"fmt"
"strconv"
"testing"
)

func BenchmarkFloat64SetMemoryUsage(b *testing.B) {
b.ReportAllocs()
type testCase struct {
rowNum int
}
cases := []testCase{
{rowNum: 0},
{rowNum: 100},
{rowNum: 10000},
{rowNum: 1000000},
{rowNum: 851968}, // 6.5 * (1 << 17)
{rowNum: 851969}, // 6.5 * (1 << 17) + 1
{rowNum: 425984}, // 6.5 * (1 << 16),
{rowNum: 425985}, // 6.5 * (1 << 16) + 1
}

for _, c := range cases {
b.Run(fmt.Sprintf("MapRows %v", c.rowNum), func(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
float64Set, _ := NewFloat64SetWithMemoryUsage()
for num := 0; num < c.rowNum; num++ {
float64Set.Insert(float64(num))
}
}
})
}
}

func BenchmarkInt64SetMemoryUsage(b *testing.B) {
b.ReportAllocs()
type testCase struct {
rowNum int
}
cases := []testCase{
{rowNum: 0},
{rowNum: 100},
{rowNum: 10000},
{rowNum: 1000000},
{rowNum: 851968}, // 6.5 * (1 << 17)
{rowNum: 851969}, // 6.5 * (1 << 17) + 1
{rowNum: 425984}, // 6.5 * (1 << 16)
{rowNum: 425985}, // 6.5 * (1 << 16) + 1
}

for _, c := range cases {
b.Run(fmt.Sprintf("MapRows %v", c.rowNum), func(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
int64Set, _ := NewInt64SetWithMemoryUsage()
for num := 0; num < c.rowNum; num++ {
int64Set.Insert(int64(num))
}
}
})
}
}

func BenchmarkStringSetMemoryUsage(b *testing.B) {
b.ReportAllocs()
type testCase struct {
rowNum int
}
cases := []testCase{
{rowNum: 0},
{rowNum: 100},
{rowNum: 10000},
{rowNum: 1000000},
{rowNum: 851968}, // 6.5 * (1 << 17)
{rowNum: 851969}, // 6.5 * (1 << 17) + 1
{rowNum: 425984}, // 6.5 * (1 << 16)
{rowNum: 425985}, // 6.5 * (1 << 16) + 1
}

for _, c := range cases {
b.Run(fmt.Sprintf("MapRows %v", c.rowNum), func(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
stringSet, _ := NewStringSetWithMemoryUsage()
for num := 0; num < c.rowNum; num++ {
stringSet.Insert(strconv.Itoa(num))
}
}
})
}
}