ddl: migrate part of ddl package code from Execute/ExecRestricted to safe API (2) (#22729) #22935
Conversation
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
ti-chi-bot
added
the
size/XL
|
@AilinKid you're already a collaborator in bot's repo. |
ddl/delete_range.go
Outdated
| @@ -346,29 +346,54 @@ func insertJobIntoDeleteRangeTable(ctx sessionctx.Context, job *model.Job) error | |||
| return nil | |||
| } | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Please resolve conflicts.
Signed-off-by: ailinkid <[email protected]>
ti-chi-bot
added
size/S
Signed-off-by: ailinkid <[email protected]>
|
/run-all-tests |
|
/LGTM |
|
/run-check_dev |
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: a07ef87
|
ti-chi-bot
added
the
status/can-merge
cherry-pick #22729 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22935After apply modifications, you can push your change to this PR via:
Signed-off-by: AilinKid [email protected]
What problem does this PR solve?
Issue Number: part close #pingcap/tidb-test#1152
What is changed and how it works?
What's Changed:
Migrate part of code in ddl package from using Execute/ExecRestricted to safe API
Attention:
1: Since partitionDef.Expr string may contain the identifier, we won't pass it as a parameter but write it to SQL string directly.
2: Since the condition string in partitionDef.less-than field contains the quotation ", so trimming need be done before it passed as a string parameter.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note