-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: optimize the performance of restore with db #22910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
/cc @eurekaka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
if tn.Schema.String() != "" { | ||
builder.WriteString(tn.Schema.String()) | ||
} else { | ||
builder.WriteString(defaultDB) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we consider the case sensitivity of the built string here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, Normalize()
would convert the string to lower case then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
if tn.Schema.String() != "" { | ||
builder.WriteString(tn.Schema.String()) | ||
} else { | ||
builder.WriteString(defaultDB) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, Normalize()
would convert the string to lower case then.
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0a2f723
|
/merge |
@rebelice: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6ec703a
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #23283 |
What problem does this PR solve?
Issue Number: close #22398
Problem Summary:
We use restore to generate SQL with default DB, it will consume more CPU. This problem will be more prominent in
batch insert
, becauseinsert
is usually faster. Also, the column list and the value list can be very long.In order to deal with this situation, for a simple
insert
, we do not use restore but string replacement.Related changes
Check List
Tests
Side effects
Release note