Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleCI: upgrade go version from 1.15 to 1.16 #22882

Merged
merged 14 commits into from
Feb 26, 2021
Merged

CircleCI: upgrade go version from 1.15 to 1.16 #22882

merged 14 commits into from
Feb 26, 2021

Conversation

ngaut
Copy link
Member

@ngaut ngaut commented Feb 23, 2021 •
edited
Loading

What problem does this PR solve?

Upgrade go version from 1.15 to 1.16

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2021
@Rustin170506
Copy link
Member

/lgtm cancel

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2021
jackysp
jackysp reviewed Feb 24, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment •
edited by ngaut
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ngaut
Copy link
Member Author

ngaut commented Feb 24, 2021

/merge

@ti-chi-bot
Copy link
Member

@ngaut: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@ngaut: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@jackysp
Copy link
Member

jackysp commented Feb 24, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2021
@jackysp
Copy link
Member

jackysp commented Feb 24, 2021

/lgtm

Seems the bot is not working in the review comment.

@coocood
Copy link
Member

coocood commented Feb 24, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • jackysp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 24, 2021
@jackysp
Copy link
Member

jackysp commented Feb 24, 2021

/merge

@ti-chi-bot
Copy link
Member

@jackysp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3c8b075

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2021
@ngaut
Copy link
Member Author

ngaut commented Feb 26, 2021

/run-all-tests

@Rustin170506
Copy link
Member

@ti-chi-bot please update this pr branch

@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

/run-unit-test

1 similar comment
@Rustin170506
Copy link
Member

/run-unit-test

@ti-chi-bot
Copy link
Member

@ngaut: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

/run-tics-test

@Rustin170506
Copy link
Member

/run-tics-test

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit f06ff9d into master Feb 26, 2021
@ti-chi-bot ti-chi-bot deleted the update-go branch February 26, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@Rustin170506 Rustin170506 Rustin170506 approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ngaut @ti-srebot @Rustin170506 @ti-chi-bot @jackysp @coocood