Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv/interface:remove kv.Storage from tikv.Storage #22868

Merged
merged 7 commits into from
Feb 23, 2021
Merged

tikv/interface:remove kv.Storage from tikv.Storage #22868

merged 7 commits into from
Feb 23, 2021

Conversation

AndreMouche
Copy link
Contributor

Signed-off-by: AndreMouche

What problem does this PR solve?

remove kv.Storage from tikv.Storage

Part of #22513

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label Feb 22, 2021
disksing
disksing previously approved these changes Feb 22, 2021
View reviewed changes
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
@andylokandy
Copy link
Contributor

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
ti-srebot
ti-srebot previously approved these changes Feb 22, 2021
View reviewed changes
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 22, 2021
@AndreMouche
make tidy
89749b2 
Signed-off-by: shirly <[email protected]>
@AndreMouche AndreMouche dismissed stale reviews from ti-srebot and disksing via 89749b2 February 22, 2021 09:03
@disksing
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22752

@ti-srebot
Copy link
Contributor

/run-all-tests

@andylokandy
Copy link
Contributor

LGTM

@andylokandy
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

jackysp
jackysp reviewed Feb 22, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

br is updated?

@disksing
Copy link
Contributor

br is updated?

yes, without updating br it won't compile

@disksing
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22760
  • 22714
  • 22418

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@AndreMouche merge failed.

@disksing
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22870
  • 22855

@disksing
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@AndreMouche merge failed.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-chi-bot
Copy link
Member

Merge canceled because a new commit is pushed.

@ti-chi-bot
Copy link
Member

@AndreMouche: Your PR has out-of-dated, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2021
@CLAassistant
Copy link

CLAassistant commented Feb 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@disksing disksing added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2021
@AndreMouche AndreMouche merged commit 99c0aba into pingcap:master Feb 23, 2021
@AndreMouche AndreMouche deleted the tikv/rmkvstoreage branch February 23, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@disksing disksing disksing approved these changes

@ti-srebot ti-srebot ti-srebot left review comments

Assignees
No one assigned
Labels
sig/transaction SIG:Transaction size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AndreMouche @andylokandy @disksing @ti-srebot @ti-chi-bot @CLAassistant @jackysp