Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: modify the switch to control global stats #22866

Merged
merged 33 commits into from
Mar 1, 2021
Merged

*: modify the switch to control global stats #22866

merged 33 commits into from
Mar 1, 2021

Conversation

rebelice
Copy link
Contributor

What problem does this PR solve?

sub-PR for the PR #22472

Problem Summary:

We modify the switch to control global-stats.

Use tidb_partition_prune_mode to control global-stats.
There are two modes:

  • static
    • do not use global stats
  • dynamic
    • try to use global stats
    • if not, use pseudo stats

design doc: link

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@rebelice rebelice requested review from a team as code owners February 22, 2021 07:26
@rebelice rebelice requested review from lzmhhh123 and removed request for a team February 22, 2021 07:26
@rebelice
Copy link
Contributor Author

/label component/statistics, sig/planner

@rebelice
Copy link
Contributor Author

/cc @Reminiscent @qw4990

@rebelice
Copy link
Contributor Author

/cc @Reminiscent, @qw4990

@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Feb 22, 2021
Reminiscent
Reminiscent reviewed Feb 22, 2021
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
qw4990
qw4990 previously approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
ti-srebot
ti-srebot previously approved these changes Feb 22, 2021
View reviewed changes
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 22, 2021
@qw4990
Copy link
Contributor

qw4990 commented Feb 22, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22846
  • 22855

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rebelice merge failed.

@rebelice
Copy link
Contributor Author

/run-tics-test tidb-test=pr/1163

@qw4990
Copy link
Contributor

qw4990 commented Feb 26, 2021

/run-all-tests tidb-test=pr/1163

1 similar comment
@rebelice
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1163

2 similar comments
@rebelice
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1163

1 similar comment
@rebelice
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

rebelice commented Mar 1, 2021

/run-all-tests tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

rebelice commented Mar 1, 2021

/run-all-tests tidb-test=pr/1163

3 similar comments
@rebelice
Copy link
Contributor Author

rebelice commented Mar 1, 2021

/run-all-tests tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

rebelice commented Mar 1, 2021

/run-all-tests tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

rebelice commented Mar 1, 2021

/run-all-tests tidb-test=pr/1163

@qw4990
Copy link
Contributor

qw4990 commented Mar 1, 2021

/run-all-tests tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

rebelice commented Mar 1, 2021

/run-all-tests tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

rebelice commented Mar 1, 2021

/run-integration-copr-test tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

rebelice commented Mar 1, 2021

/merge

@ti-chi-bot
Copy link
Member

@rebelice: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@rebelice: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rebelice
Copy link
Contributor Author

rebelice commented Mar 1, 2021

/run-all-tests tidb-test=pr/1163

@rebelice
Copy link
Contributor Author

rebelice commented Mar 1, 2021

/run-unit-test tidb-test=pr/1163

@qw4990 qw4990 merged commit e1004a2 into pingcap:master Mar 1, 2021
@overvenus
Copy link
Member

This PR breaks BR tests!

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/4978/pipeline/72/#step-933-log-139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@qw4990 qw4990 qw4990 left review comments

@ti-srebot ti-srebot ti-srebot left review comments

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
component/statistics sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rebelice @qw4990 @ti-srebot @CLAassistant @Reminiscent @ti-chi-bot @overvenus