Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mockstore: move mockstore/cluster to tikv/mockstore/cluster #22856

Merged
merged 3 commits into from
Feb 22, 2021
Merged

mockstore: move mockstore/cluster to tikv/mockstore/cluster #22856

merged 3 commits into from
Feb 22, 2021

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing [email protected]

What problem does this PR solve?

mockstore should be inside store/tikv.
Part of #22513

What is changed and how it works?

What's Changed:

  • move mockstore/cluster to store/tikv
  • rename SplitKeys(.. kv.Key) to SplitKeys(.. []byte) to avoid kv dependency

Check List

Tests

  • Unit test

Release note

  • No release note

@disksing disksing requested review from a team as code owners February 20, 2021 15:30
@disksing disksing requested review from XuHuaiyu and removed request for a team February 20, 2021 15:30
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
@disksing
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 22, 2021
@disksing
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit b74dfaf into pingcap:master Feb 22, 2021
@disksing disksing deleted the mockstore/cluster branch February 22, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression component/store sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants