store/tikv: resolve storeType dependency #22854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
|
/run-all-tests |
andylokandy
reviewed
Feb 22, 2021
kv/kv.go
Outdated
| @@ -343,6 +343,7 @@ const ( | |||
| ) | |||
|
|
|||
| // StoreType represents the type of a store. | |||
| // Type enums should sync with store/tikv.StoreType. | |||
There was a problem hiding this comment.
Why not unify these two StoreType?
There was a problem hiding this comment.
@andylokandy I discover that the 2 storeTypes are actually not strict related. There is no need to keep them synced. (I even tried to change tikv.StoreType to type string, it can still compile). So I removed the comments that declare they should be sync.
Signed-off-by: disksing <[email protected]>
|
LGTM |
ti-srebot
approved these changes
Feb 22, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@disksing merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@disksing merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing [email protected]
What problem does this PR solve?
store/tikvhas dependencies onkvandplacementto distinguish store types.Part of #22513
What is changed and how it works?
What's Changed:
store/tikvCheck List
Tests
Release note