Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix bug of mpp wrongly set schema of exchanger #22845

Merged
merged 6 commits into from
Mar 5, 2021
Merged

planner: fix bug of mpp wrongly set schema of exchanger #22845

merged 6 commits into from
Mar 5, 2021

Conversation

hanfei1991
Copy link
Member

What problem does this PR solve?

Problem Summary:
TiDB should set the right notnull flag for physical outer join's schema.
It has been fixed in Logical join but yet in Phyiscal join. This pr just port the fix.
fix pingcap/tiflash#1441

What is changed and how it works?

What's Changed:
reset not null flag if the physical plan is outer join.

Check List

Tests

  • Unit test

Release note

  • planner: fix bug of mpp wrongly set schema of exchanger

@hanfei1991 hanfei1991 added the type/bugfix This PR fixes a bug. label Feb 20, 2021
@hanfei1991 hanfei1991 requested a review from a team as a code owner February 20, 2021 08:20
@hanfei1991 hanfei1991 requested review from winoros and removed request for a team February 20, 2021 08:20
@hanfei1991 hanfei1991 added the sig/planner SIG: Planner label Feb 20, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Feb 24, 2021

could you add some tests on [mock] tiflash items of the cop and mpp?

@fzhedu fzhedu self-requested a review February 24, 2021 13:43
@hanfei1991
Copy link
Member Author

@fzhedu of course, but have to wait for #22803 being merged, right?

@tisonkun tisonkun mentioned this pull request Mar 1, 2021
Closed
@fzhedu
Copy link
Contributor

fzhedu commented Mar 2, 2021

can this PR solve pingcap/tiflash#1441?

@hanfei1991
Copy link
Member Author

@fzhedu of course

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Mar 3, 2021

/LGTM

@ti-chi-bot
Copy link
Member

@fzhedu: /lgtm is only allowed for the reviewers in list.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzhedu
Copy link
Contributor

fzhedu commented Mar 4, 2021 •
edited
Loading

@fzhedu of course

I mean including this pingcap/tiflash#1441 (comment)
after I run this commented case in your PR, the problem still happen.

@hanfei1991 hanfei1991 requested a review from a team as a code owner March 4, 2021 09:29
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Mar 4, 2021
@hanfei1991
Copy link
Member Author

@fzhedu ya, it does not solve it.

@hanfei1991
Copy link
Member Author

/cc @fzhedu @qw4990

@ti-chi-bot ti-chi-bot requested a review from qw4990 March 4, 2021 11:40
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Mar 5, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 5, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 5, 2021

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 5, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 5, 2021

/MERGE

@ti-chi-bot
Copy link
Member

@qw4990: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d917b24

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 5, 2021
@ti-chi-bot
Copy link
Member

@hanfei1991: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hanfei1991
Copy link
Member Author

/run-all-tests

@hanfei1991 hanfei1991 merged commit 505955a into pingcap:master Mar 5, 2021
@hanfei1991 hanfei1991 deleted the hanfei/fix-schema branch March 5, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros Awaiting requested review from winoros

@fzhedu fzhedu Awaiting requested review from fzhedu

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Randgen: wrong results from left join + group by
4 participants
@hanfei1991 @fzhedu @ti-chi-bot @qw4990