Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix where condition index out of range #22833

Merged
merged 2 commits into from
Feb 22, 2021
Merged

planner: fix where condition index out of range #22833

merged 2 commits into from
Feb 22, 2021

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Feb 20, 2021

What problem does this PR solve?

Issue Number: close #22828

Problem Summary: not check lIdx and rIdx in buildFuncDependCol

What is changed and how it works?

What's Changed: check the index and return an error

How it Works:

Related changes

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix where condition index out of range

@b41sh b41sh requested a review from a team as a code owner February 20, 2021 00:34
@b41sh b41sh requested review from XuHuaiyu and removed request for a team February 20, 2021 00:34
Reminiscent
Reminiscent reviewed Feb 20, 2021
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2021
@ichn-hu ichn-hu mentioned this pull request Feb 20, 2021
Closed
qw4990
qw4990 approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 22, 2021
@qw4990
Copy link
Contributor

qw4990 commented Feb 22, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 78debe7 into pingcap:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@qw4990 qw4990 qw4990 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime error: index out of range [-1]
4 participants
@b41sh @qw4990 @ti-srebot @Reminiscent