Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: push down EXTRACT to TiFlash #22832

Merged

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Feb 20, 2021

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1401

Problem Summary:

What is changed and how it works?

What's Changed:

  • Enable EXTRACT push down for TiFlash

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Support EXTRACT function push down to TiFlash

@leiysky leiysky requested a review from a team as a code owner February 20, 2021 00:33
@leiysky leiysky requested review from XuHuaiyu and removed request for a team February 20, 2021 00:33
@leiysky
Copy link
Contributor Author

leiysky commented Mar 12, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Mar 12, 2021

/cc @ichn-hu

@ti-chi-bot ti-chi-bot requested a review from ichn-hu March 12, 2021 07:01
@leiysky
Copy link
Contributor Author

leiysky commented Mar 12, 2021

/cc @LittleFall

@ti-chi-bot ti-chi-bot requested a review from LittleFall March 12, 2021 07:01
@LittleFall
Copy link
Contributor

/run-tics-test

2 similar comments
@LittleFall
Copy link
Contributor

/run-tics-test

@LittleFall
Copy link
Contributor

/run-tics-test

@LittleFall
Copy link
Contributor

/run-unit-test

@LittleFall
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@LittleFall
Copy link
Contributor

/run-unit-test

@LittleFall
Copy link
Contributor

/priority release-blocker

@ti-chi-bot ti-chi-bot added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Mar 12, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 12, 2021
@leiysky
Copy link
Contributor Author

leiysky commented Mar 12, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bbb8a78

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@lzmhhh123
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@leiysky: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b128c3c into pingcap:master Mar 12, 2021
@leiysky leiysky deleted the feature/push-down-extract-to-tiflash branch March 12, 2021 12:59
LittleFall pushed a commit to LittleFall/tidb that referenced this pull request Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EXTRACT datetime function push down
5 participants