*: apply golangci-lint to the new code

[tangenta]

What problem does this PR solve?

Fix part of #22754.

What is changed and how it works?

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch

Check List

Tests

• Unit test
• Integration test

Side effects

N/A

Release note

• No release note

[bb7133]

As reported by the CI: https://internal.pingcap.net/idc-jenkins/job/tidb_ghpr_check_2/74672/display/redirect

https://github.com/pingcap/tidb/pull/22824/files#diff-15fd19c08250c10f2c8ae4287c8c8d70eaf2b2d103bfed7c13add81053ebffb7R484 Actually returns an 'data truncated' error for ENUM, please update the test case or use MustGetError instead.

[tangenta]

This PR increases the make check-static time from 5 seconds to around 30 seconds, I am not sure if this is acceptable.

[AilinKid]

LGTM

[AilinKid]

This PR increases the make check-static time from 5 seconds to around 30 seconds, I am not sure if this is acceptable.

the 30s seem ok, how do you think it? @bb7133

[bb7133]

There are still some failed cases, please try to figure out the reasons and fix them.

[ngaut]

Good job.

[bb7133]

This PR increases the make check-static time from 5 seconds to around 30 seconds, I am not sure if this is acceptable.

the 30s seem ok, how do you think it? @bb7133

I think it's fine since it is checked in check_dev, which is not a costly CI item.

[jackysp]

LGTM

[jackysp]

/lgtm

[jackysp]

/merge

[ti-chi-bot]

@jackysp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@jackysp: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[bb7133]

/lgtm

[jackysp]

/merge

[ti-chi-bot]

@jackysp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@jackysp: /merge in this pull request requires 2 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[bb7133]

/merge

[ti-chi-bot]

@bb7133: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: faf7bad

[ti-chi-bot]

@tangenta: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.