Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv_driver: move gcworker into tikv_driver #22698

Merged
merged 10 commits into from
Feb 5, 2021

Conversation

AndreMouche
Copy link
Contributor

Signed-off-by: AndreMouche

What problem does this PR solve?

gcworker and enableGC now is part of tikv.KVStore,lets move it to tikvStore in tikv_driver

Part of #22513

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label Feb 3, 2021
store/tikv/interface.go Outdated Show resolved Hide resolved
store/gcworker/gc_worker.go Show resolved Hide resolved
disksing
disksing previously approved these changes Feb 4, 2021
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 4, 2021
andylokandy
andylokandy previously approved these changes Feb 4, 2021
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 4, 2021
ti-srebot
ti-srebot previously approved these changes Feb 4, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 4, 2021
@disksing
Copy link
Contributor

disksing commented Feb 4, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 4, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22653

@disksing
Copy link
Contributor

disksing commented Feb 4, 2021

/run-all-tests

1 similar comment
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@AndreMouche merge failed.

@disksing
Copy link
Contributor

disksing commented Feb 4, 2021

/merge

2 similar comments
@disksing
Copy link
Contributor

disksing commented Feb 4, 2021

/merge

@disksing
Copy link
Contributor

disksing commented Feb 4, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@AndreMouche merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@AndreMouche merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@AndreMouche merge failed.

@disksing
Copy link
Contributor

disksing commented Feb 4, 2021

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22668
  • 22668

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@AndreMouche merge failed.

@AndreMouche AndreMouche dismissed stale reviews from ti-srebot, andylokandy, and disksing via 4a0f127 February 5, 2021 08:08
@andylokandy
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 22729

@AndreMouche AndreMouche merged commit 6483b7d into pingcap:master Feb 5, 2021
@AndreMouche AndreMouche deleted the store/enable_gc branch February 5, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants