session: fix the duplicate binding case when updating bind info #22367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label needs-cherry-pick-4.0, sig/planner, needs-cherry-pick-5.0-rc |
|
/rebuild |
ti-srebot
approved these changes
Jan 12, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jan 12, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #22368 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jan 12, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.0-rc in PR #22369 |
ti-srebot
added a commit
that referenced
this pull request
Jan 12, 2021
…) (#22368) Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #22309
Problem Summary:
This PR will fix the duplicate binding case when updating bind info
New update method used.
We will read all bindings in the memory first. Then remove the duplicate bindings and keep only the latest. Finally, insert bindings after restoring with DB.
Related changes
Check List
Tests
Side effects
Release note