executor: store correct plan hint in statements_summary when log level is 'debug' #22219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/bugfix
Closed
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Jan 8, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@eurekaka merge failed. |
|
/run-tics-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jan 8, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #22293 |
qw4990
pushed a commit
that referenced
this pull request
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #22203
Problem Summary:
Baseline capture does not work as expected.
What is changed and how it works?
What's Changed:
Make sure
planHintis correctly set instatements_summarywhen the log level isdebugor thetidb_slow_log_thresholdis set to 0.How it Works:
getEncodedPlanmay be called inLogSlowQuerywhich would only generate encoded plan(i.e, with no plan hint), we should make sure the consequentgetEncodedPlancall inSummaryStmtcan generate plan hint then.Related changes
Check List
Tests
Side effects
N/A
Release note