-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: speed up Column.VecEvalReal by using MergeNulls #22191
Conversation
/run-all-tests |
/run-all-tests |
/run-all-tests |
Some question about tests in TiDBHad a really difficult time to debug a randgen integration test, anyway to view the integration test or to provide more info on failed tests? for instance, in this integration test, I could barely get anything useful except from panic info I hardcoded inside. |
PTAL @zhouqiang-cl |
Got, we will improve it. /cc @Tjianke |
@lzmhhh123 @qw4990 PTAL, thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@qw4990 PTAL, thanks~ |
LGTM |
/merge |
/run-all-tests |
@Tjianke merge failed. |
/run-all-tests |
What problem does this PR solve?
Issue Number: close #22190
Problem Summary:
improve efficiency of
Column.VecEvalReal()
withColumn.MergeNulls()
What is changed and how it works?
What's Changed:
expression/column.go: use
Column.MergeNulls()
before copying src element to resultRelated changes
Tests
Benchmark
use
BenchmarkVectorizedBuiltinArithmeticFunc
to benchmarkbenchmark func:
Release note
Reference
Another PR that utilized MergeNulls() to speed up functions #12674