types: support %X %V %W formats for STR_TO_DATE() #21887
Conversation
|
@tiancaiamao it's a critical bug that produces incorrect result, could you file an issue first? |
|
It's a tiny tiny bug fix for an ONCALL issue long long time ago. |
| func yearOfWeekX(t *CoreTime, input string, ctx map[string]int) (string, bool) { | ||
| v, succ := parseDigits(input, 4) | ||
| if !succ { | ||
| return input, false | ||
| } | ||
| t.setYear(uint16(v)) | ||
| ctx["X"] = 1 | ||
| return input[4:], true | ||
| } | ||
|
|
||
| func yearOfWeekx(t *CoreTime, input string, ctx map[string]int) (string, bool) { | ||
| v, succ := parseDigits(input, 4) | ||
| if !succ { | ||
| return input, false | ||
| } | ||
| t.setYear(uint16(v)) | ||
| ctx["x"] = 1 | ||
| return input[4:], true | ||
| } | ||
|
|
||
| func weekModeV(t *CoreTime, input string, ctx map[string]int) (string, bool) { | ||
| v, succ := parseDigits(input, 2) | ||
| // v should be in [01, 53] | ||
| if !succ || v <= 0 || v > 53 { | ||
| return input, false | ||
| } | ||
| ctx["WeekNumber"] = v | ||
| ctx["SundayFirst"] = 1 | ||
| ctx["V"] = 1 | ||
| return input[2:], true | ||
| } | ||
|
|
||
| func weekModeU(t *CoreTime, input string, ctx map[string]int) (string, bool) { | ||
| v, succ := parseDigits(input, 2) | ||
| // v should be in [00, 53] | ||
| if !succ || v < 0 || v > 53 { | ||
| return input, false | ||
| } | ||
| ctx["WeekNumber"] = v | ||
| ctx["SundayFirst"] = 1 | ||
| ctx["U"] = 1 | ||
| return input[2:], true | ||
| } | ||
|
|
||
| func weekModev(t *CoreTime, input string, ctx map[string]int) (string, bool) { | ||
| v, succ := parseDigits(input, 2) | ||
| // v should be in [01, 53] | ||
| if !succ || v <= 0 || v > 53 { | ||
| return input, false | ||
| } | ||
| ctx["WeekNumber"] = v | ||
| ctx["v"] = 1 | ||
| return input[2:], true | ||
| } | ||
|
|
||
| func weekModeu(t *CoreTime, input string, ctx map[string]int) (string, bool) { | ||
| v, succ := parseDigits(input, 2) | ||
| // v should be in [00, 53] | ||
| if !succ || v < 0 || v > 53 { | ||
| return input, false | ||
| } | ||
| ctx["WeekNumber"] = v | ||
| ctx["u"] = 1 | ||
| return input[2:], true | ||
| } |
There was a problem hiding this comment.
It seems that most of the codes are duplicates, can we simplify them?
There was a problem hiding this comment.
No, not duplicated.
Take a close look, you will find the tiny different between those functions. @wjhuang2016
There was a problem hiding this comment.
I see. Can we take the difference as a parameter? Will it hurt the performance?
ti-chi-bot
added
the
size/L
ti-chi-bot
added
the
needs-rebase
ti-chi-bot
removed
the
needs-rebase
ti-chi-bot
added
the
needs-rebase
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
ti-chi-bot
removed
the
needs-rebase
|
@tiancaiamao: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
MySQL:
TiDB:
Problem Summary:
%X %V %Wformats are not supportedWhat is changed and how it works?
What's Changed:
Support
%X %V %Wfor STR_TO_DATE()How it Works:
It works the same with MySQL after this change.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note
%X%Vand%Wformat for builtin functionSTR_TO_DATE()