Add bencher for raw API #2109
Merged
Add bencher for raw API #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disksing
reviewed
Nov 28, 2016
|
|
||
| // without conflict | ||
| func batchRawPut(value []byte) { | ||
| cli, err := tikv.NewRawKVClient([]string{"localhost:2379"}) |
There was a problem hiding this comment.
Use strings.Split(*pd, ",") instead. The rest LGTM.
ngaut
force-pushed
the
ngaut/bench-raw
branch
from
5930e1b to
1f3f860
Compare
|
LGTM |
|
PTAL @siddontang |
siddontang
reviewed
Nov 28, 2016
| Help: "Counter of txns.", | ||
| }, []string{"type"}) | ||
|
|
||
| txnRolledbackCounter = prometheus.NewCounterVec( |
siddontang
reviewed
Nov 28, 2016
| pdAddr = flag.String("pd", "localhost:2379", "pd address:localhost:2379") | ||
| valueSize = flag.Int("V", 5, "value size in byte") | ||
|
|
||
| txnCounter = prometheus.NewCounterVec( |
There was a problem hiding this comment.
seem you don't need use MetricVec, using Counter is enough.
|
Rest LGTM |
|
Removed all of the unnecessary metrics. It's much more clean now. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.