first MVCC support #209
Merged
first MVCC support #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a simple mvcc get/scan for kv
pass the golint check.
speed up CI builds
|
PTAL |
| // Next returns the next key in byte-order | ||
| func (k Key) Next() Key { | ||
| // add \x0 to the end of key | ||
| return append(append([]byte(nil), []byte(k)...), 0) |
There was a problem hiding this comment.
This should allocate slice twice?
First allocing a slice with same size with k, then appending 0 also re-allocs another slice with size len(k) + 1 ?
buf := make([]byte, len(k) + 1)
copy(buf, k)
return buf
maybe more efficient, I don't know.
c4pt0r
force-pushed
the
c4pt0r/MVCC-support
branch
from
d60db6a to
975a746
Compare
| } | ||
|
|
||
| // Cmp returns the comparison result of two key, if A > B returns 1, A = B | ||
| // returns 0, if A < B returns -1. |
There was a problem hiding this comment.
Comment if A > B returns 1, else if A = B returns 0, else returns -1.
There was a problem hiding this comment.
The result will be 0 if a==b, -1 if a < b, and +1 if a > b.
See http://golang.org/pkg/bytes/#Compare
c4pt0r
force-pushed
the
c4pt0r/MVCC-support
branch
2 times, most recently
from
27e80f3 to
20180eb
Compare
Address code review comments
|
LGTM |
1 similar comment
|
LGTM |
| ) | ||
|
|
||
| func init() { | ||
| mc.cache = make(map[string]*dbStore) | ||
| globalVerProvider = &LocalVersioProvider{} |
There was a problem hiding this comment.
LocalVersioProvider -> LocalVersionProvider
This was referenced Dec 12, 2019
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO (I'll put them in next commits, to avoid a big PR):
the structure of MVCC kv:
Key1 => 3 (newest version)
Key1_3 => ... (value of this version)
Key1_2 => ... (value of this version)
Key2 => 2
Key2_2 => Tombstone (this key is deleted in the version)
Key2_1 => ...
Key3 => 4
Key3_4 => ...