Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add max font size limit (#20625) #20637

Merged
merged 1 commit into from
Oct 26, 2020
Merged

executor: add max font size limit (#20625) #20637

merged 1 commit into from
Oct 26, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20625 to release-4.0

Signed-off-by: crazycs520 [email protected]

What problem does this PR solve?

Close #20624

What is changed and how it works?

Add max font size limit.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • No

Release note

  • Fix issue of generated metric profile failed

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Oct 26, 2020
Merged
@ti-srebot ti-srebot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Oct 26, 2020
@ti-srebot ti-srebot added this to the v4.0.8 milestone Oct 26, 2020
tangenta
tangenta reviewed Oct 26, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2020
breezewish
breezewish approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

@breeswish, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIGs: ddl(slack),execution(slack).

@jebter
Copy link

jebter commented Oct 26, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @jebter, this branch cannot be merged without an approval of release maintainers

SunRunAway
SunRunAway approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 26, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @SunRunAway, you don't have permission to trigger auto merge event on this branch.

@jebter
Copy link

jebter commented Oct 26, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit f1edb86 into pingcap:release-4.0 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@breezewish breezewish breezewish approved these changes

@SunRunAway SunRunAway SunRunAway approved these changes

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees

@crazycs520 crazycs520

Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.8
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @jebter @SunRunAway @breezewish @tangenta @crazycs520