*:Speed up parse slow-log when query slow_query #15371 (#19139) #20556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
ti-srebot
added
contribution
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Signed-off-by: jyz0309 <[email protected]>
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/run-all-tests |
ti-srebot
added
status/LGT2
crazycs520
approved these changes
Oct 21, 2020
|
/merge |
|
Sorry @crazycs520, this branch cannot be merged without an approval of release maintainers |
SunRunAway
approved these changes
Oct 21, 2020
ti-srebot
added
status/LGT3
|
/merge |
ti-srebot
added
the
status/can-merge
|
/rebuild |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19139 to release-4.0
What problem does this PR solve?
Issue Number: close #15354
Problem Summary:
After Issue #15354 laster, the performance improvement is not significant. The Read slow log file and parse process are slow.
What is changed and how it works?
What's Changed:
In the slow log query process, the two steps of reading the log and parsing the log have been serialized. Here, the step of parsing the log is put into the go routine to make it concurrent.
For query 300M tidb-slow.log:
-- before this PR;
Spend 4.75s
-- this PR;
Spend 1.25-1.30s
Improve slow log query efficiency by 4 times.
How it Works:
the step of parsing the log is put into the go routine to make it concurrent.
Related changes
pingcap/tidb/executor/slow_query.go:Check List
Tests
Side effects
Release note