metric: add metric for pessimistic lock keys #20383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs520 <[email protected]>
|
LGTM |
ti-srebot
approved these changes
Oct 10, 2020
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Oct 19, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #20513 |
ti-srebot
added a commit
that referenced
this pull request
Oct 21, 2020
Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs520 [email protected]
What problem does this PR solve?
As the title said. relate issue: #18942
Here is an example of metric profile:
before
You must be weird, why
commitstatement cost so much time intidb_execution?This PR:
Now, you will be more clear, because there are some time cost in
lock keys,tidb_executioncost is very low.What is changed and how it works?
Add metrics.
Related changes
Check List
Tests
Side effects
Release note