Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix a bug that from_unixtime + union all returns truncated result #20225

Merged
merged 2 commits into from
Sep 27, 2020
Merged

expression: fix a bug that from_unixtime + union all returns truncated result #20225

merged 2 commits into from
Sep 27, 2020

Conversation

wjhuang2016
Copy link
Member

Signed-off-by: wjhuang2016 [email protected]

What problem does this PR solve?

Issue Number: close #20223

Problem Summary:
For from_unixtime, Flen is set to the length of the second argument, which is not necessary.

What is changed and how it works?

Don't set flen.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • fix a bug that from_unixtime + union all returns truncated result

@wjhuang2016
done
7ba9952 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016 wjhuang2016 requested a review from a team as a code owner September 25, 2020 11:32
@wjhuang2016 wjhuang2016 requested review from wshwsh12 and removed request for a team September 25, 2020 11:32
@cfzjywxk
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2020
qw4990
qw4990 approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 27, 2020
@qw4990 qw4990 added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@wjhuang2016 merge failed.

@wjhuang2016
Copy link
Member Author

/run-sqllogic-test-1

@wjhuang2016 wjhuang2016 merged commit 5eaaa5c into pingcap:master Sep 27, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 27, 2020
@wjhuang2016 @ti-srebot
cherry pick pingcap#20225 to release-4.0
b1a57ec 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 27, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20240

zz-jason pushed a commit that referenced this pull request Oct 3, 2020
@ti-srebot
expression: fix a bug that from_unixtime + `unio ... (#20225) (#20240)
65747bf
@wjhuang2016 wjhuang2016 deleted the fix_from_unixtimestamp branch November 17, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@qw4990 qw4990 qw4990 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

from_unixtime + union all returns truncated result
4 participants
@wjhuang2016 @cfzjywxk @ti-srebot @qw4990