Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix sort result for batch-point-get by unsigned pk #20108

Merged
merged 6 commits into from
Sep 24, 2020
Merged

executor: fix sort result for batch-point-get by unsigned pk #20108

merged 6 commits into from
Sep 24, 2020

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Sep 18, 2020 •
edited
Loading

What problem does this PR solve?

Issue Number: close #20100

Problem Summary:

batch point sort handle before batch-get but didn't take care handle maybe uint

What is changed and how it works?

What's Changed, How it Works:

sort as uint when it's unsigned pk

Related changes

  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Unit test

Side effects

  • n/a

Release note

  • fix sort result for max unsigned int in batch-point-get

This change is Reviewable

@lysu lysu requested a review from a team as a code owner September 18, 2020 12:45
@lysu lysu requested review from qw4990 and removed request for a team September 18, 2020 12:45
@lysu lysu requested review from coocood and lzmhhh123 September 18, 2020 12:45
@lysu lysu added the type/bugfix This PR fixes a bug. label Sep 18, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Sep 18, 2020
@ti-srebot
Copy link
Contributor

@coocood, @qw4990, @lzmhhh123, PTAL.

qw4990
qw4990 reviewed Sep 22, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2020
@lysu lysu requested a review from lzmhhh123 September 23, 2020 03:25
lzmhhh123
lzmhhh123 reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 24, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lysu merge failed.

@lysu
Copy link
Contributor Author

lysu commented Sep 24, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 20175

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lysu merge failed.

@lysu
Copy link
Contributor Author

lysu commented Sep 24, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 20064

@lysu lysu added this to the v4.0.8 milestone Sep 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 10fd834 into pingcap:master Sep 24, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 24, 2020
@lysu @ti-srebot
cherry pick pingcap#20108 to release-4.0
fc5bb13 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 24, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20205

ti-srebot added a commit that referenced this pull request Oct 3, 2020
@ti-srebot
executor: fix sort result for batch-point-get by unsigned pk (#20108) (…
7eab75c 
…#20205)

Signed-off-by: ti-srebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@qw4990 qw4990 qw4990 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v4.0.8
Development

Successfully merging this pull request may close these issues.

unexpected results returned by BatchPointGet
4 participants
@lysu @ti-srebot @lzmhhh123 @qw4990