Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support show variables where syntax #200

Merged
merged 6 commits into from
Sep 20, 2015
Merged

support show variables where syntax #200

merged 6 commits into from
Sep 20, 2015

Conversation

siddontang
Copy link
Member

try to fix #199

@shenli

@coocood
Copy link
Member

coocood commented Sep 19, 2015

I also noticed that WhereClauseOptional returns WhereRset but all statements don't use that rset, but only use the expression.

@ngaut
Copy link
Member

ngaut commented Sep 19, 2015

Please add some tests.

@siddontang
Copy link
Member Author

@coocood

WhereClauseOptional returns a WhereRset, but I just want to use an expression to keep thing simple.
But if your following pr merged, maybe we can use it.

@ngaut
Copy link
Member

ngaut commented Sep 20, 2015

Also you need to add some tests to parser.

@siddontang siddontang changed the title [DMN] support show variables where syntax support show variables where syntax Sep 20, 2015
@siddontang
Copy link
Member Author

PTAL @ngaut @coocood

ngaut
ngaut reviewed Sep 20, 2015
View reviewed changes
tidb_test.go
r := mustExecSQL(c, se, "show variables where variable_name = 'autocommit'")
row, err := r.FirstRow()
c.Assert(err, IsNil)
match(c, row, "autocommit", 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line.

@ngaut
Copy link
Member

ngaut commented Sep 20, 2015

LGTM

@qiuyesuifeng
Copy link
Member

LGTM

qiuyesuifeng added a commit that referenced this pull request Sep 20, 2015
@qiuyesuifeng
Merge pull request #200 from pingcap/siddontang/fix-issue-199
14096e3 
support show variables where syntax
@qiuyesuifeng qiuyesuifeng merged commit 14096e3 into master Sep 20, 2015
@qiuyesuifeng qiuyesuifeng deleted the siddontang/fix-issue-199 branch September 20, 2015 11:37
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
@kennytm
go.mod: update dependencies (pingcap#200)
9d55221
xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021
@spongedu @tiancaiamao
[parser] types: Fix description for year type (pingcap#200)
5cd8a09
xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021
@spongedu @xhebox
[parser] types: Fix description for year type (pingcap#200)
663f548
ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021
@spongedu @ti-chi-bot
[parser] types: Fix description for year type (#200)
f9f7fa9
okJiang pushed a commit to okJiang/tidb that referenced this pull request Oct 19, 2021
@lichunzhu
add MySQL chaos test (pingcap#200)
f623ee0 
* refine pick index logic
* add mysql connection chaos test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support show variables where syntax
4 participants
@siddontang @coocood @ngaut @qiuyesuifeng