server: add auth switch to mysql_native_password (#19603) #19959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
|
/run-all-tests |
|
LGTM |
ti-srebot
added
status/LGT2
This was referenced Sep 12, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
jackysp
approved these changes
Sep 16, 2020
|
@ti-srebot merge failed. |
|
/run-integration-compatibility-test |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19603 to release-4.0
What problem does this PR solve?
Issue Number: Fixes #17875
Problem Summary:
The TiDB server does not allow clients from MySQL 8 servers to connect when they have a password.
What is changed and how it works?
What's Changed:
Support for MySQL 8 clients has been added.
How it Works:
The MySQL protocol allows the server to ask the client to change authentication plugins. This does not explicitly allow support for MySQL 8's
caching_sha2_password, but it sidesteps the issue to allow MySQL 8 clients to connect to TiDB. Any client that speakscaching_sha2_passwordis asked to change to usemysql_native_password.Related changes
(It is certainly not required, butI think this is useful enough to cherry-pick.)
Check List
Tests
The go mysql connector does not permit sending
caching_sha2_password, and then being downgraded, so it is hard to include in the testsuite directly under./server/server_test.go. What I did was used a MySQL 8.0 CLI and performed the following:This confirms that it both allows non-passworded accounts and passworded to work correctly.
Side effects
Release note