Add golint package get in makefile and update ci. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiuyesuifeng
changed the title
|
PTAL |
qiuyesuifeng
changed the title
| @@ -11,7 +11,7 @@ LDFLAGS += -X "github.com/pingcap/tidb/util/printer.TiDBGitHash=$(shell git rev- | |||
|
|
|||
| TARGET = "" | |||
|
|
|||
| .PHONY: godep deps all build install parser clean todo test tidbtest mysqltest gotest interpreter | |||
There was a problem hiding this comment.
AFAIK make server will be failed for go 1.4.2.
There was a problem hiding this comment.
. PHONY section is only to support make section conflicting with dir or filename. It will not make server.
|
LGTM |
1 similar comment
|
LGTM |
ngaut
added a commit
that referenced
this pull request
Sep 20, 2015
Add golint package get in makefile and update ci.
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* test: speed up TestGetJSON Force a shorter timeout on the HTTP client, so that accessing `http://not-exists` won't take 30 seconds. * config,lightning: implement "server mode" In "Server Mode" Lightning will wait for tasks submitted via the HTTP API `POST /tasks`, and will keep running until Ctrl+C. Multiple tasks are executed sequentially. The config is split into "Global config" and "Task config", which shares the same structure for compatibility and simplicity. The pprof-port setting has been deprecated in favor of status-addr, for compatibility with other tools. * lightning,config: cover some of the new code * lightning: added `GET /tasks` API to get number of queued tasks * *: addressed comments * config,lightning: use a linked hash map to store queued configs Changed /task to return JSON. This is to prepare for an API removing a queued task, and also to remove the artificial task queue size limit. * config: change TaskID to record the current timestamp
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* restore: adjust PD config to speed up restore Signed-off-by: Neil Shen <[email protected]> * address comments Signed-off-by: Neil Shen <[email protected]> * tests: disable TLS test Signed-off-by: Neil Shen <[email protected]> * Update pkg/task/restore.go Co-Authored-By: kennytm <[email protected]> * restore run post work after restore files success Signed-off-by: Neil Shen <[email protected]> * restore TiKV/PD config before validating checksum Signed-off-by: Neil Shen <[email protected]> * defer splitPostWork Signed-off-by: Neil Shen <[email protected]> * Update pkg/task/restore.go Co-authored-by: kennytm <[email protected]> * task: remove sync Signed-off-by: Neil Shen <[email protected]> Co-authored-by: kennytm <[email protected]>
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
guo-shaoge
pushed a commit
to guo-shaoge/tidb
that referenced
this pull request
Feb 14, 2023
* remove slow query Signed-off-by: David <[email protected]> * hide statement tables as well Signed-off-by: David <[email protected]> --------- Signed-off-by: David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.