expression: fix keepNull option for istrue
function
#19600
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17720
Problem Summary:
isTrueOrFalseFunctionClass.keepNull
was initialized differently in expression rewriter andEvaluateExprWithNull
, which causedouter join
wrongly simplified toinner join
during predicate push down optimization.What is changed and how it works?
What's Changed:
isTrueOrFalseFunctionClass
withnewFunctionImpl
.How it Works:
ScalarFunction
inwrapWithIsTrue
. InvokeNewFunctionInternal
instead.sessionctx.Context
to pass the argumentis_true_keep_null
, which affects the evaluation ofNULL
in functionistrue
.Related changes
Check List
Tests
Release note
istrue
function whennull
is involved