-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix show table regions bug #19562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhuang2016
reviewed
Aug 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
ti-srebot
approved these changes
Sep 8, 2020
AilinKid
reviewed
Sep 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT3
The PR has already had 3 LGTM.
and removed
status/LGT2
Indicates that a PR has LGTM 2.
labels
Sep 9, 2020
/run-all-tests |
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Sep 9, 2020
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 9, 2020
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #19895 |
zimulala
pushed a commit
that referenced
this pull request
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT3
The PR has already had 3 LGTM.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close: pingcap/br#477
Problem Summary:
when the last region has the endKey is as same as the range endKey. show table regions will return
ERROR 1105 (HY000): PD returned no region
errorWhat is changed and how it works?
What's Changed:
break when last scan region has same endkey with range endKey.
How it Works:
it won't scan next round, and return immediately
Related changes
Check List
Tests
before this commit:
MySQL [d]> show table t1 regions; ERROR 1105 (HY000): PD returned no region
with this commit:
works well
Release note