Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix show table regions bug #19562

Merged
merged 5 commits into from
Sep 9, 2020

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Aug 28, 2020

What problem does this PR solve?

close: pingcap/br#477
Problem Summary:
when the last region has the endKey is as same as the range endKey. show table regions will return ERROR 1105 (HY000): PD returned no region error

What is changed and how it works?

What's Changed:

break when last scan region has same endkey with range endKey.

How it Works:

it won't scan next round, and return immediately

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    before this commit:
    MySQL [d]> show table t1 regions; ERROR 1105 (HY000): PD returned no region

with this commit:
works well

Release note

  • Fix the issue that will raise no regions error when table range end key and region endKey are same.

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 28, 2020
@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 8, 2020
@AilinKid AilinKid modified the milestone: v4.0.6 Sep 9, 2020
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 9, 2020
@AilinKid
Copy link
Contributor

AilinKid commented Sep 9, 2020

/run-all-tests

@AilinKid
Copy link
Contributor

AilinKid commented Sep 9, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 9, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19752
  • 19832

@ti-srebot
Copy link
Contributor

/run-all-tests

@AilinKid AilinKid merged commit 0b306ef into pingcap:master Sep 9, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 9, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19895

zimulala pushed a commit that referenced this pull request Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore data from three replica cluster to five replica cluster, show table table_name regions not work.
5 participants